Warning: Can't synchronize with repository "(default)" (Unsupported version control system "svn": No module named svn). Look in the Trac log for more information.

Ticket #749 (closed enhancement: fixed)

Opened 13 years ago

Last modified 12 years ago

[PATCH] Toolbox: make breadcrumbs more consistent

Reported by: roger.demetrescu Owned by: anonymous
Priority: low Milestone:
Component: Toolbox Version: 0.9a4
Severity: minor Keywords:
Cc: Ronald

Description

  • "Toolbox » ModelDesigner?" doesn't show Toolbox anchor with decoration. Any other tool have a consistent breadcrumb (anchors have underline as decoration).
  • With the new feature of having a separate view for some widgets, it would be nice to have the name of the widget at the end of breadcrumbs, like:
    Toolbox » Widget Browser » Scriptaculous 
    Toolbox » Widget Browser » Lightbox
    

The following patch makes this improvements.

Attachments

breadcrumbs.patch Download (1.7 KB) - added by roger.demetrescu 13 years ago.
catwalk_css.patch Download (365 bytes) - added by roger.demetrescu 13 years ago.

Change History

Changed 13 years ago by roger.demetrescu

comment:1 Changed 13 years ago by roger.demetrescu

  • Summary changed from Make Toolbox's breadcrumbs more consistent to [PATCH] Make Toolbox's breadcrumbs more consistent

comment:2 Changed 13 years ago by roger.demetrescu

  • Summary changed from [PATCH] Make Toolbox's breadcrumbs more consistent to [PATCH] Toolbox: make breadcrumbs more consistent

comment:3 Changed 13 years ago by roger.demetrescu

My patch will conflict with the patch from #761 (turbogears/toolbox/widgets.kid)... but since this patch is really easy to merge, I suggest applying the #761 first (if both are approved)...

comment:4 Changed 13 years ago by michele

Hi Roger,

I will try to commit your patches tomorrow if no one does it. ;)

Thanks!

comment:5 Changed 13 years ago by roger.demetrescu

Hi Michelle,

Don't need to be in a hurry to commit them... It was just and advice to prevent a "hey Roger, the #761 is broken..." :)

I did a quick review of the other patches remaining and it seems that they don't touch the Kid files from Toolbox... phew !!

[]s

comment:6 Changed 13 years ago by michele

  • Status changed from new to closed
  • Resolution set to fixed

Committed at r1173. Thanks Roger!

comment:7 Changed 13 years ago by roger.demetrescu

  • Status changed from closed to reopened
  • Cc Ronald added
  • Resolution fixed deleted

I see "Toolbox » Catwalk" doesn't show Toolbox anchor with decoration either.

I am attaching a very little patch (catwalk_css.patch).

Cheers

PS: I am CC Ronald just to make sure he agrees with these changes

Changed 13 years ago by roger.demetrescu

comment:8 Changed 13 years ago by elvelind

  • Status changed from reopened to closed
  • Resolution set to fixed

commited in 1898.

Note: See TracTickets for help on using tickets.