Warning: Can't synchronize with repository "(default)" (Unsupported version control system "svn": No module named svn). Look in the Trac log for more information.

Ticket #761 (closed defect: fixed)

Opened 13 years ago

Last modified 12 years ago

[PATCH] Toolbox: cleanup html warnings

Reported by: roger.demetrescu Owned by: anonymous
Priority: normal Milestone:
Component: Toolbox Version: 0.9a4
Severity: normal Keywords: tidy


Using the  Tidy Html Validator extension for Firefox, we can see a tons of html warnings...

The following patch tries to solve 99% of theses warnings:

  • <link> inserting "type" attribute
  • <style> inserting "type" attribute
  • <script> inserting "type" attribute
  • <link> attribute "text" has invalid value "text/css"
  • <img> lacks "alt" attribute
  • <form> lacks "action" attribute
  • <style> isn't allowed in <body> elements
  • </code> before <pre>
  • replacing <p> by <br>
  • inserting implicit <br>
  • missing <tr>
  • <script> isn't allowed in <table> elements

There are still some warnings remaining like:

  • <table> proprietary attribute "cellpading"
  • <table> proprietary attribute "cellpading"

and also these ones (they come from widget's templates):

  • <input> proprietary attribute "autocomplete"
  • <img> proprietary attribute "src2"
  • <img> lacks "alt" attribute
  • <div> proprietary attribute "name"


tidy_toolbox.patch Download (25.9 KB) - added by roger.demetrescu 13 years ago.

Change History

Changed 13 years ago by roger.demetrescu

comment:1 Changed 13 years ago by roger.demetrescu

  • Summary changed from [PATCH] Cleanup Toolbox's html warnings to [PATCH] Toolbox: cleanup html warnings

comment:2 Changed 13 years ago by michele

  • Status changed from new to closed
  • Resolution set to fixed

Committed at r1172. Thanks Roger!

Note: See TracTickets for help on using tickets.