Warning: Can't synchronize with repository "(default)" (Unsupported version control system "svn": No module named svn). Look in the Trac log for more information.

Ticket #987 (closed defect: fixed)

Opened 11 years ago

Last modified 10 years ago

Querystring arguments have limitations on their names

Reported by: david.marsh@… Owned by: anonymous
Priority: lowest Milestone: 1.0b2
Component: TurboGears Version: 0.9a5
Severity: minor Keywords:
Cc:

Description

While working on a turbogears related project (seen here:  http://groups.google.com/group/turbogears/browse_thread/thread/bbdab36b87485267/2dbb30605d185aa6?lnk=arm#2dbb30605d185aa6), I have run into a small problem.

I am trying to use the word 'template' as one of my query string arguments. However, on line 290 in controllers.py there is an issue. Turbogears complains about getting duplicate entries for the keyword "template".

Upon examining line 290, the reason becomes clear:

_execute_func(_func, template, format, content_type,mapping, fragment, *args, kw))). The querystring argument is conflicting with the hardcoded argument. Due to the nature of the project, I cannot change the name of my argument to avoid this conflict.

Any work-arounds or suggestions would be appreciated

Change History

comment:1 Changed 11 years ago by jorge.vargas

  • Priority changed from normal to lowest
  • Severity changed from normal to minor
  • Milestone changed from 1.0b1 to 1.0b2

it's line 231

http://trac.turbogears.org/turbogears/browser/tags/0.9a5/turbogears/controllers.py#L231

and that is not hardcored in tg, we need to name the variable. somehow.

if someone provides a patch renaming it to _template I'm sure noone will complain about the change.

comment:2 Changed 11 years ago by alberto

  • Status changed from new to closed
  • Resolution set to fixed

This was fixed by a patch at #1066 which I comitted at [1803] with a test-case covering specifically this scenario. I think I forgot to close this at that moment, sorry.

Note: See TracTickets for help on using tickets.